[Bug 7667] division by zero possible in latest update

[b***@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7667

Bill Cole <***@apache.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@apache.org
Status|NEW |RESOLVED
Resolution|--- |WORKSFORME

--- Comment #1 from Bill Cole <***@apache.org> ---
We don't have a deep analysis of this bug, but it has only been reported with
obsolete unsupported versions of SpamAssassin (3.3.x) which would be consistent
with CentOS 5.x or any other EL5-family distribution. The specific error
message is generated by SpamAssassin, not Perl itself. The relevant code (in
Mail::SpamAssassin::Conf::Parser) has undergone extensive revision between
3.3.2 and 3.4.2..

You may be able to upgrade SA to v3.4.2 using CPAN, because in principle SA
v3.4.2 supports Perl v5.8.1 or newer. If you do so and still encounter this
issue, please reopen this bug.

[b***@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7667

--- Comment #5 from Bill Cole <***@apache.org> ---
(In reply to RW from comment #4)

Why not just rewrite it as
... && (__E_LIKE_LETTER < 10*__LOWER_E )
and have done with it.

Good idea.

Done.

[b***@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7667

Kevin A. McGrail <***@apache.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@apache.org

--- Comment #2 from Kevin A. McGrail <***@apache.org> ---
What version of spamassassin is on the system? We can at least add a version
conditional to the rule.

Regards,
KAM

[b***@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7667

--- Comment #6 from ***@users.sourceforge.net ---
I built and installed 3.4.2, but still get the same error on CentOS 5:

# sa-update
config: invalid expression for rule T_MIXED_ES: "( __LOWER_E > 20 ) && (
__E_LIKE_LETTER > ( (__LOWER_E * 14 ) / 10) ) && ( ( __E_LIKE_LETTER /
__LOWER_E ) < 10 )": division by zero possible

[b***@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7667

***@users.sourceforge.net changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|WORKSFORME |FIXED

--- Comment #3 from ***@users.sourceforge.net ---
Version 3.3.2 (spamassassin-3.3.2-56.el5). But the interesting thing is, that
on CentOS 6 I have spamassassin-3.3.1-3.el6, and update worked there, there is
T_MIXED_ES rule in /var/lib/spamassassin/3.003001/72_active.cf.
I will try to build 3.4.2.

[b***@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7667

RW <***@googlemail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@googlemail.com

--- Comment #4 from RW <***@googlemail.com> ---
Why not just rewrite it as

... && (__E_LIKE_LETTER < 10*__LOWER_E )

and have done with it.

[b***@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7667

***@users.sourceforge.net changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@users.sourceforge.n
| |et